complex-upset icon indicating copy to clipboard operation
complex-upset copied to clipboard

Replace `base_annotations` with `intersection_size`

Open krassowski opened this issue 2 years ago • 1 comments

base_annotations is redundant to annotations. Very often users want to customize the intersection size bar plot and they should be able to just pass upset(..., intersection_size=intersection_size(<user args>) rather than specify lengthy base_annotations=list('Intersection size'=intersection_size(<user args>)). There is no value lost as the intersection size could be moved to any place using annotations. Specifying intersection_size=FALSE (or "none") would disable it.

krassowski avatar Aug 10 '21 21:08 krassowski

Maybe it could use a different name from intersection_size to distinguish function creating the subplot from upset() argument as it was done for matrix. So maybe just size? Or maybe more formally size_plot (which will allow users to abbreviate to size.

krassowski avatar Aug 10 '21 21:08 krassowski