Michał Krassowski

Results 1112 comments of Michał Krassowski

Thanks for the PR. Yes, a version of jupyterlab-lsp would get installed for the user, and it would be compatible with the jupyterlab version that they currently have installed, but...

Interesting, I cannot reproduce, neither on master nor on Binder with an older version (using python-lsp-server): ![cannot-repro](https://user-images.githubusercontent.com/5832902/175399075-4a1a67cc-bffc-4ba2-8786-c156dddc5474.gif) There is selector for the case if language server returns multiple targets (#739)...

I can see that pyright returns both options. In the current stable version indeed the first one is always chosen. On master (with #739) we get a rudimentary selector: ![jumpselector](https://user-images.githubusercontent.com/5832902/175406531-78cd7294-364a-4c55-acfd-f862b173dbb8.gif)...

:+1: I think that we would want to merge PRs: #636, #731, #778 before we start diverging the codebases. #636 would benefit from code review. The remaining two need some...

This can be addressed by adding a CSS style for the `` tag using a selector like `body[data-jp-theme-light='false'] .lsp-signature-help mark` to https://github.com/jupyter-lsp/jupyterlab-lsp/blob/master/packages/jupyterlab-lsp/style/signature.css - contributions welcome.

It sounds like this likely originates from pylsp (or one of its underlying packages). Would you be able to confirm that this also happens when using pylsp with another editor...

Sorry for the late response, but I would have thought that it already works. Have you encountered problem with either of these approaches?

Hi @bilucodota thanks for getting in touch! I would love to enable all extensions to combine their completions, and users to have a way to specify in which order they...