jupyterlab-lsp
jupyterlab-lsp copied to clipboard
jupyter-lsp
Remove jupyterlab version constraints
References
The built artifact on pypi and conda-forge takes care of the version constraints (<4) for jupyterlab. We could probably remove the explicit upper bounds from the user installation bits in the README.
User-facing changes
A bit more cleaner installation instructions for the user.
Thanks! Let me know if I am missing something here :)
:point_left: Launch a binder notebook on branch MridulS/jupyterlab-lsp/jlab_version
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for the PR. Yes, a version of jupyterlab-lsp would get installed for the user, and it would be compatible with the jupyterlab version that they currently have installed, but that version would not be the same as described in README. Not a strong opinion here - I think that the range was introduced by @bollwyvl initially so curious to hear if there are other packaging concerns.
If we were to accept this change, could you please update the integrity tests? I believe there is a check verifying that this version is correct and removing the version will cause that check to fail.
Closing as stale. I am happy to reconsider this suggestion if we were to move the feature descriptions to documentation (so that the version in README would not need to be synced with the descriptions in README itself).