Jump to definition bug with repeated definitions

[mlucool]

Description

If a function is defined twice, jump to definition always jumps to the first definition and not the latest.

Reproduce

Expected behavior

The second add should jump to the add right above it.

Context

• Operating System and version: Linux (server)
• Browser and version: Chrome
• JupyterLab version: 3.4.1
• Language server and version: Tried with both [email protected] and [email protected] [email protected]

[krassowski]

Interesting, I cannot reproduce, neither on master nor on Binder with an older version (using python-lsp-server):

There is selector for the case if language server returns multiple targets (#739) but it was not released yet; in any case it seems pylsp returns only the correct match. It could however vary depending on dependencies of pylsp itself (jedi?).

[krassowski]

I can see that pyright returns both options. In the current stable version indeed the first one is always chosen. On master (with #739) we get a rudimentary selector:

We can improve the rendering of it greatly (e.g. show the actual cell) in the future.

[krassowski]

@mlucool the jump target selector was included in v4.0.0. Can we close this issue?