Sergii Karpenko

Results 40 comments of Sergii Karpenko

Hi @velo, thanks for being community member. From the very beginning it was clear that we have totally different vision and targets regarding this repo. From my side I just...

@velo @kdavisk6 Guys it's your turn. Better make some decision and move forward.

Do you mean `feign.Logger`?

'feign.Logger' is not designed for reactive work. Can introduce ReactorLogger but don't have enough reason for this as SLF4J is also a high level abstraction.

Do you mean `feign.codec.Encoder` ?

feign.codec.Encoder doesn't meant for reactive encoding. I suggest that exact implementation of `ReactiveHttpClient` should implement encoding/decoding. In case of implementation based on Spring WebClient I don't need encoding/decoding as Spring...

What about to wrap Reactor core implementation with reactor.adapter.rxjava.RxJava2Adapter to provide RxJava2 types support? Will it work for Android clients?

From my side I can offer to follow (and may try to implement) this approach (wrapper over Reactor) as not sure how fast pure RxJava2 version will be implemented (guess...

Do you mean `feign.codec.Decoder` ?

`feign.codec.Decoder` doesn't meant for reactive decoding. I suggest that exact implementation of `ReactiveHttpClient` should implement encoding/decoding. In case of implementation based on Spring `WebClient` I don't need encoding/decoding as Spring...