feign-reactive icon indicating copy to clipboard operation
feign-reactive copied to clipboard

Add Logger Support

Open kdavisk6 opened this issue 6 years ago • 4 comments

The current implementation is locked to SLF4J. We replace this with support for the Logger abstraction.

kdavisk6 avatar Aug 16 '18 17:08 kdavisk6

Do you mean feign.Logger?

kptfh avatar Aug 17 '18 07:08 kptfh

Yes.

kdavisk6 avatar Aug 17 '18 14:08 kdavisk6

'feign.Logger' is not designed for reactive work. Can introduce ReactorLogger but don't have enough reason for this as SLF4J is also a high level abstraction.

kptfh avatar Aug 17 '18 15:08 kptfh

I disagree, and we shouldn't ask users of OpenFeign to throw away concepts that are prevalent across all of our other integrations. There are ways to take a synchronous process and make it reactive. Take the reactor documentation itself, B.1. How do I wrap a synchronous, blocking call?.

Feign favor Composition over Inheritance. It is reasonable for us to be able add support for both a native Reactive approach and an approach that allows users to use existing Synchronous Feign constructs. By doing so we can increase the likely hood of this projects adoption.

kdavisk6 avatar Aug 17 '18 16:08 kdavisk6