feign-reactive icon indicating copy to clipboard operation
feign-reactive copied to clipboard

Published 20 hours ago • verified publisher icon OpenFeign

Add RxJava2 Support

Open kdavisk6 opened this issue 7 years ago • 4 comments

Similar to Reactive, we should support RxJava2 and their Streams implementation.

kdavisk6 avatar Aug 16 '18 17:08 kdavisk6

What about to wrap Reactor core implementation with reactor.adapter.rxjava.RxJava2Adapter to provide RxJava2 types support? Will it work for Android clients?

kptfh avatar Aug 17 '18 09:08 kptfh

That is one approach to this, but wouldn't that require both reactor and rxjava2 to work?

With regards to Android, rxjava2 is recommended, but reactor should work if the SDK version is higher than 26. See Reactor Prerequisites

If we want to support Android, I think we should keep rxjava2 and reactor explicitly separate.

kdavisk6 avatar Aug 17 '18 14:08 kdavisk6

From my side I can offer to follow (and may try to implement) this approach (wrapper over Reactor) as not sure how fast pure RxJava2 version will be implemented (guess it may take years :( ).

kptfh avatar Aug 17 '18 15:08 kptfh

We can help with that. These issues are not tasks for you to take on, only to keep track of what I think would be good features for use to consider.

kdavisk6 avatar Aug 17 '18 16:08 kdavisk6