Kamil Owczarz

Results 12 comments of Kamil Owczarz

Hey, sorry for being offline I had a sick leave from Wednesday to Friday and I wasn't able to get to the computer. I've fixedt these all things you've mentioned.

@akinwale yes, it should be fixed in https://github.com/Expensify/App/pull/30829/commits/0fb774da9121831725bbe3ddfb69de09e9703769

BTW we are aware of that the PR breaks no-new-js-files, [but we decided to skip it and solve it as a followup ](https://swmansion.slack.com/archives/C05NJ4SLBMF/p1706040000354629?thread_ts=1705946907.401049&cid=C05NJ4SLBMF)

@akinwale bump

@francoisl fixed ✅

>On mobile platforms (native and mweb), we can hide the volume control and set the player volume to max (not enitrely sure how expo-av handles this or if it's all...

> Inline playback in the chat report on mobile. [It was discussed here](https://expensify.slack.com/archives/C01GTK53T8Q/p1684350588417249) and there was decision not to do it. > Auto-switch to fullscreen when the device is rotated...

@akinwale I've addressed all your notes, feel free to recheck it.

@francoisl Oh, I missed the issue with not loading attachment preview on android. That's pretty weird, because it should work in the way it's implemented right now. I will contact...

While preparing a repro of the issue with not loading attachment preview on android I spotted that it's a bug caused by `react-native-image-picker`, with `expo-image-picker` everything works fine. It seems...