Kostiantyn Stepaniuk
Kostiantyn Stepaniuk
@Gnappuraz and I reviewed it, and this issue occurs because we want to finalize epoch not when 2/3 of votes are reached but when ">2/3" of votes are reached. The...
The reason we have `target_epoch` besides `target_hash` is that we don't want to download the entire fork to figure out if we want to slash or not, so we rely...
There is a small chance that we will bump into the case when merged PR is broken because of the change on a master. But there are already tools that...
@scravy https://github.com/dtr-org/unit-e/pull/883 seems not related much to this. Do you mean https://github.com/dtr-org/unit-e/pull/885 ?
I support dropping Version and use only types. As an intermediate approach (if we find cases that Version is convenient to have), would suggest separating `txtype` and `version`. Instead of...
for the record ["Fake Stake" attacks on chain-based Proof-of-Stake cryptocurrencies](https://medium.com/@dsl_uiuc/fake-stake-attacks-on-chain-based-proof-of-stake-cryptocurrencies-b8b05723f806)
Technically we should have `p2p_*.py` test for every p2p message we have. But I see our p2p tests check too much. Should we have `p2p__schema.py` separately or you plan to...
@castarco I think genesis block fits better the design then chainparams, so yeah, I think we should go with genesis block. But in the end, what is important is that...
Yes, we plan to run this test. I'd need to re-work this test a bit to test that there are no issues with fast sync/snapshot.
@scravy @castarco what if the probability of winning with 1 coin was slightly higher than when splitting it by 2? Then everyone would have an incentive to keep as little...