Kostiantyn Stepaniuk

Character \r causes lex_string_invalid_json_char error

1

Having `\r` character as a value breaks unmarshaling, however this symbol doesn't cause any issue using native Go implementation.

Unfortunately, I don't have enough time to work on this gem now. If you feel you can contribute to it, please, reach me via email or leave a comment on...

Optimize String method

2

New String() method is approximately 14 times faster Benchmarks: ``` BenchmarkStringNew 20000000 121 ns/op 48 B/op 1 allocs/op BenchmarkStringOld 1000000 1709 ns/op 269 B/op 9 allocs/op ```

Proposal to use stretchr/testify in tests

3

Motivation of using this package in tests is to have a nice error message and write less code https://github.com/stretchr/testify

Remove instant finalization

2

**Is your feature request related to a problem? Please describe** Instant finalization is not something that will be at the mainnet. I see it as a leftover when we didn't...

Replace command name with byte code in p2p message

2

**Is your feature request related to a problem? Please describe** This is the header of any p2p message: ``` // (4) message start // (12) command // (4) size //...

**Is your feature request related to a problem? Please describe** Initial discussion started here: https://github.com/dtr-org/unit-e/pull/852#discussion_r272167308 When node syncs, it receives headers+commits. At this step, we verify that commits are correct,...

After fast sync wallet is not in the same state as after pruning

3

**Is your feature request related to a problem? Please describe** 1. [ ] After the fast sync, wallet transactions don't have inputs (as they are not part of UTXO) and...

Finalizer doesn't create the vote after the checkpoint is processed

4

**Describe the bug** As tests from the following PR https://github.com/dtr-org/unit-e/pull/617 show, the finalizer creates the vote once it sees the first block of the new epoch. It means that the...

We have basic test coverage of finalization. We need to create a list of extensive finalization scenarios that we need to cover. - [ ] Test that finalization is happening...