Derek Cormier

Results 36 comments of Derek Cormier

I added a second commit to run the example e2es against locally built packages.

I can't reproduce the error, so going to close.

Yep I can take that for my 20%.

@devversion Not sure if this is in line with our earlier discussion. You had mentioned something involving `exec properties` which I didn't try here.

Some of the examples inline fonts or scripts, hence the need to add `requires-network` to those tests. I could change those options in the example boilerplate `angular.json` files, but that...

Since this PR is small, I added a few drive-by commits to green up more jobs in the CI. Hope you don't mind.

Okay, CI looks green enough for this PR. ~There are some issues with the `test_aio_local` job but I'll deal with that in a separate PR.~

Updated the first commit to do what we discussed re. networking, @devversion. Can replace with the `exec_properties` constant here if we want this: https://github.com/angular/dev-infra/pull/826

I did a first draft. Probably missing some things, but it would be good to have some feedback at this point.