Sebastian Staudt

Results 104 comments of Sebastian Staudt

ruby-head has been fixed with 46939f3521eed0f12157c3a20a1a077cf51d17d1. For Rubinius see #15.

A fix for this is enforcing to use a pre-1.0 version of `http`. ``` ruby gem 'http', '< 1.0' ``` The real fix must be done in `reel-rack` though.

I decided to cherry-pick the typo fixes and HTTPS change for now. Additionally, I added an optional switch to fallback to plain HTTP. You might want to rebase on current...

Did you close this by mistake or is there a specific reason?

Would you mind rebasing this on `master` first?

What’s the exact benefit here? This will lead to nil related errors in the affected code… instead of? Other errors?

Using `fetch-depth: 0` will cause the refspec for tags to be added, effectively removing the `--no-tags` option: https://github.com/actions/checkout/blob/ec3a7ce113134d7a93b817d10a8272cb61118579/src/git-command-manager.ts#L175-L177 Apparently, this might not be enough depending on your workflow. I‘m currently...

Your first change would effectively make this check obsolete, because the `if` statement can never be `true`. The second one seems to be more appropriate, although I’m not entirely sure...