Mitsunori Komatsu

Results 65 comments of Mitsunori Komatsu

Thanks for the PR and sorry for my late reply. I looked at the PR and I found that AsyncRawSocketSender.emit() and flush() create anonymous Runnable every time. It can cause...

Plan2 looks simple. But as mentioned earlier, if we adopt checked exception, the users need to change their code. If adopting unchecked exception, the users' applications can be troubled because...

@xerial I just sent a PR for this issue. Can you look at it when you have a time? In the PR, I added only `ServerErrorHandler` which deals with errors...

@xerial Thanks for the comments. I added additional changes according to your comment. But I'm still wondering if we should prepare a default error handler since I have a concern...

There is no way to send multiple messages at once for now. I think you want an API like this: ``` public class FluentLogger { public class Record { private...

@cosmo0920 Oh really sorry, I failed to notice the notifications of this project. Let me see the changes.

@cosmo0920 @mxk1235 Thanks for the PRs! I left some comments. Also, it needs unit tests in principle. BTW, as I commented earlier, AsyncRawSocketSender creates a thread for each invoking `emit()`...

I fixed some test failures at https://github.com/fluent/fluent-logger-java/commit/969b88d0d1ed9a5aa27e92ccc72621d524c76cdf. Could you try `git rebase master` to it?

@cosmo0920 Thanks! I left some comments on the diff. Especially, https://github.com/fluent/fluent-logger-java/pull/49/files#r61833474 is an issue, I think. BTW, will you actually use AsyncRawSocketSender? If so, what do you think about creating...