fluent-logger-java icon indicating copy to clipboard operation
fluent-logger-java copied to clipboard

enable some asynchronous logging

Open mxk1235 opened this issue 9 years ago • 4 comments

AsyncRawSocketSender is just a wrapper around RawSocketSender that does its work in a separate thread.

also added a factory method to create a logger with its own sender, and moved from using a synchronized method to using a synchronizedMap for the loggers.

mxk1235 avatar Sep 04 '14 19:09 mxk1235

Thanks for the PR and sorry for my late reply.

I looked at the PR and I found that AsyncRawSocketSender.emit() and flush() create anonymous Runnable every time. It can cause a poor performance.

So I think we'd better use consumer-producer model to implement async sender. What do you think?

komamitsu avatar Sep 11 '14 15:09 komamitsu

sorry for the late reply. yes, performance might be an issue. but i think i'd rather let someone else do that refactoring. i am currently in the middle of a different task at work, which no longer has anything to do with AsyncRawSocketSender.

mxk1235 avatar Sep 22 '14 21:09 mxk1235

changed to nested classes.

mxk1235 avatar Nov 26 '14 02:11 mxk1235

@komamitsu @mxk1235 can this PR be revived? Could we handle the concerns Mitsunori Komatsu had

anusricorp avatar Aug 26 '20 19:08 anusricorp