Koen Punt comments

Results 284 comments of


                                            Koen Punt

added enable, disable and deselect

And just realized I've created another problem by only enabling the select when it is not already enabled. Because this way the focus event will never be applied to already...

use a tag instead of abbr tag for search-choice-close

@mlettini do you have anything to say about this?

use a tag instead of abbr tag for search-choice-close

Updated per @stof's comment about using a button. Removed some duplicate CSS in the process.

Tap to Pay `localMobileReaderDidAcceptTermsOfService` fires on every connection?

I think this is by design, so when using the simulated terminal you get the events more often.

Make search match against text instead of html

Thanks for your contributions! Over the years there has been quite a lot to do about matching html or text (eg. https://github.com/harvesthq/chosen/issues/1150 and https://github.com/harvesthq/chosen/pull/1638), so accepting a change like this...

Make search match against text instead of html

And a bit more recent: #2254

Make results_search run after keyup of Cmd key

Thanks! However I think the issue can also be solved by listening to the `input` event, instead of `keyup`. Using `input` has been proposed before as a fix for other...

Add Settings -> Skirt and brim, is missing skirt.

The skirt is for all objects on the sheet, but it still would be nice to have a way to add the setting in a single project, instead of having...

Ignore context (right click) mousedown events

Wouldn't a function `is_left_click` suffice? As the others are never considered.

Update install to install from release tarball instead of a git repo

I don't see the relation with #379.. Or do you mean that you won't be testing nvm from the `.nvm` dir?