Koen Punt

Results 284 comments of Koen Punt

@rstoyanchev I'm not sure about whether the combination with Spring Security annotations now works, since we stopped using that because it didn't work well together with Spring R2DBC (overfetching data...

> The problem comes from ReactDOMServer The error is thrown there. However I believe the problem is Next specific, so the rendering of Next might be messing up proving the...

Nice work! What is the status on this? And wouldn't it be more convenient to call the option `:delay` and let it default to `true`: ``` rb process :set_metadata, :delay...

Why did you close this? I still think this is valuable.

Snapshot build for IJ2024.1: [2.0.20-alpha.0.3+20240526T093157Z-SNAPSHOT-IJ2024.1.zip](https://github.com/spekframework/spek/files/15446943/2.0.20-alpha.0.3%2B20240526T093157Z-SNAPSHOT-IJ2024.1.zip)

It is not really a callback, so I think naming it `value_transformer` would make more sense IMO.

A callback is generally called on completion, not in the middle of a transaction. But let's wait for @satchmorun's opinion.

Even though I see the value in this, I still think there's too much logic involved for a feature that only certain people will use. Would it be possible to...

What I mean is that the `winnow_results` function is already complex, and this adds more complexity to it, so if extract the highlighting from `winnow_results` to a `highlight_result` function, that...

A little while back I talked with @pfiller about this PR, and we both agreed that we're not really happy with the complexity involved with the proposed changes. But we...