Koen Punt

Results 284 comments of Koen Punt

> Maybe we could even consider injecting an alternative `ReactiveDataLoader` type that returns `Mono` instead of `CompletableFuture`. So returning a mono is supposed to work for dataloaders? In comparison; awaiting...

Alright, good to know it's spring graphql specific. I suppose this could be extended to support coroutines too?

Between M2 and M3 argument serialization changed from JSON encode/decode to using a `DataBinder`, which caused some things to work differently, or not work at all anymore. I experienced something...

See also the comments on this PR: https://github.com/spring-projects/spring-graphql/pull/140

Maybe sometimes, but otherwise we have to create entities just for matching a response, which is not something we want. The methods in the controller do data conversion quite often,...

> The tester supports the full JSONPath syntax We know, and it does come in handy in a lot of cases. > We could consider support for setting a path...

@rstoyanchev any more thoughts on this? Have been writing stuff like this again today: ```kt .path("merchant.contentClassification.id").isEqualTo( contentClassification.id!!.encodeGlobalId() ) .path("merchant.contentClassification.name").isEqualTo( contentClassification.name ) .path("merchant.contentClassification.description").isEqualTo( contentClassification.description ) .path("merchant.contentClassification.excludeFromSitemap").isEqualTo( contentClassification.excludeFromSitemap ) ``` And would...

I do now realize that I could use something like this: ```kt val mapTypeRef = object : ParameterizedTypeReference() {} // ... .path("merchant.contentClassification").entity(mapTypeRef).isEqualTo( mapOf( "id" to contentClassification.id!!.encodeGlobalId(), "name" to contentClassification.name, "description"...

Thanks, but it still has some issues 🙁. After running it now, it did somehow connect to a device of a colleague over WiFi, but after connecting my phone with...