Kristján Oddsson
Kristján Oddsson
Hey @gullerya; can you add a minimal reproduction steps of the issue you are having?
Damn this is weird. I feel like `chai.assert.strictEqual(NaN,NaN)` and should not fail and `chai.assert.strictEqual(-0,0)` should not pass. I'll dig into this. cc/ @keithamus as someone that might know if this...
I guess `NaN !== NaN` so it does make some sort of sense.
Also `-0 === 0` now that I think about it.
Then reading the `deep-eql` README, it says: >- Strict equality for non-traversable nodes according to [Object.is](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is): >. - `eql(NaN, NaN).should.be.true;` >. - `eql(-0, +0).should.be.false;`
Makes me think this is indeed working as expected but maybe a bit confusing.
Started a draft PR here. I'll be slogging through the types and trying to get them all done before the new year but who knows how long it will take...
I keep going in circles but this is starting to look like the solution to me. > * require that consumers do something like `chai = chaiOriginal.use(foo).use(bar);` I also wonder...
> The docs under https://www.chaijs.com/plugins/chai-files/ are unfortunately not yet updated. Bit of a mess to introduce a breaking change and forget to update the docs IMHO. I love the work...
> Well, if i knew how to then i'd do that instead of sharing my issue here, wouldn't I? ;-) No worries! All the information that you need should be...