Kristján Oddsson
Kristján Oddsson
I pushed some changes that fix the issue but there are some other issues that pop up. Mostly because there are still requires in the codebase which now error.
@keithamus; I'm probably doing something wrong but `chai.request` seems to be undefined even though the function that's passed into `chai.use` sets `chai.request` to the correct object.
> > `chai.request` seems to be undefined even though the function that's passed into `chai.use` sets `chai.request` to the correct object. > > Can confirm this, so could this be...
> This could very well break a lot of the base functionality of the drawer, I'll also check it locally in a few days. Any news on this? We've been...
Just hit this in our codebase and we've currently got it monkey-patched. It would be great to remove that patch with these changes merged upstream 🙏🏻
> * [ ] Finna út hvort það sé hægt að [tengjast aftur kjörskrá](https://github.com/kristjanmik/kjosturett-web/blob/master/src/lib/kjorskra.js?rgh-link-date=2024-10-13T17%3A00%3A38Z) með sambærilegum hætti Þetta virðist virka fyrir mig allavegana.
> > > * [ ] Finna út hvort það sé hægt að [tengjast aftur kjörskrá](https://github.com/kristjanmik/kjosturett-web/blob/master/src/lib/kjorskra.js?rgh-link-date=2024-11-13T08%3A12%3A38Z) með sambærilegum hætti > > > > > > Þetta virðist virka fyrir mig...
`equals` is essentially just a short-hand for `===` and [in JavaScript `NaN !== NaN`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NaN#description) so to me chai is doing the correct thing here. Node was special casing their implementation...
Could we just change this to MIT instead of dual-licening? I believe `@domenic` gave the go-ahead in https://github.com/chaijs/chai-as-promised/issues/176