Kristján Oddsson

Results 139 comments of Kristján Oddsson

I'm cleaning up some old PRs and am gonna close this. I'll re-open a different one if I end up working on this.

I hope you don't mind that I hacked on this quickly while waiting at a airport. I tried to make sure that the history was preserved in doing this.

Hey hey! I haven't had a lot of time to work on this but I would 100% accept a PR for this.

You also need to run `npm run bootstrap` in order to pull the submodules containing the vendored libraries.

I ended up taking the [jsperf test](https://jsperf.com/selectorset-match/) linked on the `selector-set` README and adding a new case for the `Map` lookup and found it performs about the same as linear....

I wanted to check what the difference this change has on code on github.com and added the following performance measuring to the `getMatches` call and ran some form submissions. I...

It would also be helpful if anyone has any ideas on how to run tests with a specific safari version. I just have version 17 installed on my machine and...

> [...] we should introduce a workflow action to check this We have a meta test in https://github.com/github/eslint-plugin-custom-elements/blob/main/test/check-rules.js that makes sure that each rule is documented in a specific way...

Running this on `github/github`, I'm getting false positives for `` elements that have `content_tag` or ViewComponents with `tag: :summary`. I feel like I gotta fix those before merging.

This is harder than I thought since Heroku doesn't offer this redirect.