Petr Kobalicek

Results 307 comments of Petr Kobalicek

I created a branch in asmjit repo, which blindly implements the support - I used WebKit as a documentation in this case. If anyone wants to try it (you would...

I think there may be missing `MemoryFlags::kMapShared` on this line (function `allocDualMappingUsingMachVmRemap`): ``` ASMJIT_PROPAGATE(mapMemory(&rxPtr, size, MemoryFlags::kAccessReadWrite)); ``` Should be: ``` ASMJIT_PROPAGATE(mapMemory(&rxPtr, size, MemoryFlags::kAccessReadWrite | MemoryFlags::kMapShared)); ``` I think this needs...

I have looked into it again and updated the branch. I actually borrowed a real x86 mac to try it and it worked on that machine. Wondering whether you can...

A fix has been merged to asmjit: https://github.com/asmjit/asmjit/commit/a63d41e80ba72f652c450d3bd6614327cde8531c It now uses the mentioned `mach_vm_remap` to create dual mapping.

@jhogberg I would probably not worry about it being undocumented as I have found the use of the function in other projects, including DoxBox and V8: https://github.com/v8/v8/blob/main/src/base/platform/platform-darwin.cc#L198 So, most likely...

I don't plan to work on this. I would review a PR adding this feature though. Or anyone willing to sponsor it?

Closing as this is not planned at the moment. AsmTK will most likely merge with AsmJit in the future - and then it will be time to support everything AsmJit...

The linked PR was not merged, so I guess this issue could be closed as well.

That's something I would consider in AsmJit, but it needs the following: - the feature must be supported by all backends (both x86 and aarch64) - the feature needs tests...

@Asadalk I'm afraid there are no beginner friendly issues here - the best is to start using AsmJit and fix what makes your life harder - that's usually the way...