Kenzo Lobos Tsunekawa

Results 44 comments of Kenzo Lobos Tsunekawa

Note to self. Rebase if needed

@vividf LGTM does not apply in this case. We will put all of our documentation here before merging. hence draft

@vividf General comments: - There are several grammar/spelling/redaction/cohesion mistakes. Please, read the documents again, and use a tool like grammarly (you can use it in vscode) - During the tutorials,...

@vividf I checked both the main documentation and the tutorial for the tag based pnp calibrator. However, there are still many issues. Please be careful with your redaction. I will...

@vividf Thank you for your reviews. I addressed them, and it seems you already resolved the conversations. Regarding my earlier comments, some of them did not receive an answer from...

Btw, Did you check the new installation instructions and the docker? Also, please be as critical as you can with my own documentation (that is the reason we have reviewers;...

@vividf With respect to the background model in the radar-lidar calibrator, there is not enough explanation regarding why we need such a background model. It lacks the motivation

@vividf I do not know if you haven't finished yet, but the documentation for radar-lidar is insufficient (package's documentation). Since unlike other algorithms like PnP or SfM which are well...

@vividf Once you properly finish the documentation in a way that covers all the required steps in a way that the user can comprehend the idea and the process drop...

@vividf As I am not keen on this cycle of eternal reviews, I only took a look a the radar-lidar documentation and the briefest of looks to its tutorial. Nevertheless,...