Roscoe Rubin-Rottenberg comments

Results 54 comments of


                                            Roscoe Rubin-Rottenberg

🐞 deleteConfimartion alert shows incorrect count when deleting a nested folder

working on this

✨ Autocomplete angle bracketed components the same way braces are autocompleted

In addition to JSX and TSX, it should also apply to regular JS and TS files as JSX and TSX can be written inside regular JS and TS files.

delete warning message uses enumerator instead of shallow search

> How well does this perform if the folder contains many files, like a node_modules folder? I'd be willing to sacrifice exact file count for speed if a case like...

delete warning message uses enumerator instead of shallow search

@thecoolwinter does this look good to you?

delete warning message uses enumerator instead of shallow search

That sounds like a good limit to me, I just made that change.

delete warning message uses enumerator instead of shallow search

I believe when someone deletes things, they should be informed what is being deleted so they don't accidentally delete more than they intended, especially in the "Delete Permanently" option. we...

delete warning message uses enumerator instead of shallow search

so should I change it to not say the item count and just the file name?

delete warning message uses enumerator instead of shallow search

I think if we want to be as close to Xcode UI as possible, we should display the count.

delete warning message uses enumerator instead of shallow search

@austincondiff what do you think?

delete warning message uses enumerator instead of shallow search

Okay @austincondiff, I'll implement that.