CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

🐞 deleteConfimartion alert shows incorrect count when deleting a nested folder

Open plbstl opened this issue 1 year ago • 2 comments

Description

When I was working on #1694, I noticed that the deleteConfimartion alert shows incorrect count when deleting a nested folder. This happens on the main branch.

It can resolved by scanning the directory recursively instead of doing a shallow search. fileManager.contentsOfDirectory is currently used to retrieve file count

To Reproduce

  1. Open a project in CodeEdit
  2. Right click a nested folder
  3. Click on Delete

Expected Behavior

Should show the correct number of items that are going to be deleted

Version Information

CodeEdit: 0.1.0-alpha macOS: 14.4.1 Xcode: 15.3

Additional Context

No response

Screenshots

context menu delete alert

plbstl avatar Apr 30 '24 21:04 plbstl

working on this

knotbin avatar Apr 30 '24 23:04 knotbin

Oh sorry, I did not write that I worked on the bug. I wanted the linked PR to be focused on one thing only, so I was waiting on it being merged or closed

plbstl avatar May 01 '24 04:05 plbstl