kmcfaul

Results 48 comments of kmcfaul

PR updated - - Changes to utilize wrapping divs now require the `removeFindDomNode` flag (Popper, and components that use Popper have this new prop). - Functions may also be passed...

Opened #7872 to track a future breaking change to enable the wrapping divs by default.

@jschuler Updated the typings and also added a strict mode example. I was able to get the Menu keyboard handling to work by calling the `setPopperElement` inside the passed function...

Resolved the handful of demos that were no longer rendering due to a syntax error after the rebase. I'm not sure why, but several examples having an optional prop was...

@jschuler Yeah I've been on and off trying to debug that. The example uses functions to bypass the findDOMNode call, which I've tweaked to allow keyboard navigation to continue to...

I've removed the functional version of bypassing the strict mode error for now as the initial position is not updating properly. We can revisit this method in the future if...

I opened this codesandbox to reproduce the use case: https://codesandbox.io/s/snowy-bush-7zx6m9?file=/index.tsx:5705-5714 Putting the toolbar inside or outside above `OuterScrollContainer` appear to functionally make the toolbar sticky (the `{toolbar}` in the sandbox...

Yeah the codesandbox has the wrapping div to show the scrolling (otherwise the preview just keeps expanding the table). Adding a divider is a good idea as well. So I...

Yeah that might be a nice feature to add, should be straightforward to add that on the react side too

Hosted the codesandox on the PF sandbox account to preserve it. (link: https://codesandbox.io/s/sticky-table-with-sticky-toolbar-dec9ox)