Results 107 comments of kleonc

> Same as #97248, duplicate of #96081. Hence closing this issue. > This issue is already solved in 4.4 dev2. And it's cherry-picked into 4.3.1 (not yet released).

Regarding PR/commit title "Fix" would be better than "fixing": > ~fixing~Fix `changed` signal emission in `Curve::set_point_offset` Haven't thought you'd use my suggestion from https://github.com/godotengine/godot/pull/96296#discussion_r1986979848 as is. :upside_down_face:

You're right, the calculation is indeed reversed and should be fixed.

> It might be a good idea to add directives like @warning_ignore_start("unused_signal") @warning_ignore_end(("unused_signal") or @warning_ignore_file("unused_signal")? @vittorio There are [`@warning_ignore_start`](https://docs.godotengine.org/en/4.5/classes/[email protected]#class-gdscript-annotation-warning-ignore-start) and [`@warning_ignore_restore`](https://docs.godotengine.org/en/4.5/classes/[email protected]#class-gdscript-annotation-warning-ignore-restore) available since 4.4.dev7 (added in #76020).

Note you could tile an AtlasTexture with a custom shader using `REGION_RECT` (see #90436), something like: ```gdshader shader_type canvas_item; instance uniform vec2 rect_size; void fragment() { vec2 region_position = REGION_RECT.xy;...

> [@kleonc](https://github.com/kleonc) BTW, is it allowed to integrate custom shaders into node source code (I mean, directly inside official Godot source)? So there will be no need for user to...

I agree it might be confusing/surprising (you're a living proof🙃). A PR clarifying this would be welcomed! Changing _"radius of the sphere"_ to _"radius of the sphere's equator"_ also makes...