godot icon indicating copy to clipboard operation
godot copied to clipboard

Fix curve edit `set_point_position`

Open aryan-11825114 opened this issue 1 year ago • 2 comments

Fixes #95752

Before

before.webm

After

after.webm

aryan-11825114 avatar Aug 29 '24 18:08 aryan-11825114

Hey there, I was just wondering if this could be merged sooner, it would mean the world for a newbie contributor like me 😀

aryan-11825114 avatar Sep 14 '24 04:09 aryan-11825114

cc. @Geometror

adamscott avatar Oct 05 '24 11:10 adamscott

Didn't find this PR before opening my PR, but this PR breaks the curve if the point ends up at a different index after being dragged and also when you try to undo such change (If you want to fix it I'll close my PR)

passivestar avatar Mar 09 '25 12:03 passivestar

Didn't find this PR before opening my PR, but this PR breaks the curve if the point ends up at a different index after being dragged and also when you try to undo such change (If you want to fix it I'll close my PR)

Yes, thank you, I have rebased and modified the P.R., it is now identical to yours

aryan-11825114 avatar Mar 09 '25 14:03 aryan-11825114

Regarding PR/commit title "Fix" would be better than "fixing":

~fixing~Fix changed signal emission in Curve::set_point_offset

Haven't thought you'd use my suggestion from https://github.com/godotengine/godot/pull/96296#discussion_r1986979848 as is. :upside_down_face:

kleonc avatar Mar 10 '25 12:03 kleonc

ht you'd use my suggestion from #96296 (comment) as is. 🙃

Sorry not a creative person myself, also english is my second language 😅

aryan-11825114 avatar Mar 10 '25 12:03 aryan-11825114

Thanks!

Repiteo avatar Mar 10 '25 15:03 Repiteo

Cherry-picked for 4.4.1.

akien-mga avatar Mar 12 '25 11:03 akien-mga