kkmuffme

Yes please, take your time. I grabbed them off of psalm only taking global, non-class functions

I'm just used to psalm/phpstan and using threads has a net-positive when using just 2 files :-) I guess since you added parallel you benchmarked this at some point in...

Benchmarked this now and identified the issues: For example: (ran this 10 times on identical/unmodified files, this is what I got on one run, but this is a good average...

I don't know about "EasyParallel" specifically, as it's the first time explicitly using it, but commonly there is a CLI argument to specify e.g. "--threads" (e.g. psalm) or "--parallel" (e.g....

Phpstan for example https://github.com/phpstan/phpstan-src/blob/a97bdead71d24694dfe2bbe96de80486119b27a1/src/Parallel/Scheduler.php#L28-L45 The docs for phpstan parallel can be found here: https://phpstan.org/config-reference#parallel-processing

https://github.com/rectorphp/rector/blob/1d28ca109ca536e8034c3c756ee61c65e6e63c8a/vendor/symfony/contracts/Deprecation/function.php#L26 We do not really need to bubble up Symfony deprecations to Rector release, so removing this function seems the way to go. Comment this line/empty this function will fix...

@bor0 your example is an associative array, not a list. This issue is purely for lists. See here what a list is: https://psalm.dev/docs/annotating_code/type_syntax/array_types/

The question is also if "explicit" casts should be handled separately then? (or the $explicit_cast should be removed altogether, as it's basically unused)

@AndrolGenhald yes we should keep the $explicit_cast and make it work - I just found there's issues `ImplicitToStringCast` so we could make this work here too for the object __toString...

I think the way class_exists suppresses it is fine and should be xtended to instanceof. If we add UndefinedInstanceofClass, then this must give an error too: https://psalm.dev/r/efcdbbdfa0 (which would be...