kkmuffme

Results 280 comments of kkmuffme

>This is an ambiguous case, because it's not clear whether the translator comment is meant for the first call or the second. Even then, translators comments should not be applied...

Translators comments should still only be applied once. >Using multi-line statements is a reasonable workaround to avoid all potential issues. Have you tried that? Yes, in some cases that isn't...

Just normally with phpdoc for the $args I'd say ``` /** * @param string $foo * @param int */ wp_schedule_single_event( strtotime( '+ 2 days' ), 'my_custom_cron_hook', array( $foo, 10 )...

It's easy enough with nikic PHP parser directly in enterNode function for e.g. wp_schedule_single_event: (for wp_schedule_event index is 2 instead of 1) ``` if ( in_array( (string) $node->name, $event_functions, true...

Is there maybe some way I can custom add this (like a custom visitor or something I can declare when calling the hooks generator)? bc I realized there are some...

Same issue also in /src/Plugin_Command.php line 650: `$update_info = ( isset( $all_update_info->response[ $file ] ) && null !== $all_update_info->response[ $file ] ) ? (array) $all_update_info->response[ $file ] : null;` should...

@schlessera could you apply this fix? (since pull request for this small thing is more work than necessary for this minor fix)

In my opinion this should even be the default behavior

Fix https://github.com/orklah/psalm-strict-equality/issues/6 now too (except for lists? since we kind of expect lists to have the same ordering, that's the whole reason why list is used, isn't it?)

@orklah if you have a few mins I'd really appreciate some feedback on this