Krešimir Klas

Results 57 comments of Krešimir Klas

Thanks for continuing the effort!

Use case - writing a unit test for AMM Pool https://github.com/kunalabs-io/sui-smart-contracts/blob/master/amm/move/sources/amm.move#L85. Without `destroy_supply_for_testing` you can only do `test_scenario` tests.

`muldiv` would also be nice to have. I use it a lot in my modules (and copy paste it every time). ``` /// Calculates (a * b) / c. Aborts...

anchor-cli is a dev dependency. Are you trying to build `anchor-client-gen` from this repo or just using it as a dependency in you project? If the former, then update to...

@tnowacki agree with everything. I'm waiting for other comments to do round 2 here.

The bigger question I'd have is how to upstream the tests https://github.com/kunalabs-io/sui-client-gen/blob/master/ts/tests/source.test.ts. These e2e tests are **very** important. They cover many things, including function call arg encoding for all the...

@Jordan-Mysten in that case will you guys do it or can you give me some pointers for where this code should be located and some examples? I imagine ideally we'd...

Thanks @stefan-mysten. In that case I think it might be best to: - copy the whole test setup into the `test` directory of the `sui-client-gen` crate (including the whole typescript...

@hayes-mysten so from what I understand, your setup is actually very similar to what I described above, with the difference being that the e2e tests would live in the SDK...