Krešimir Klas
Krešimir Klas
@hayes-mysten awesome stuff, thanks for setting this up I think it's great! For running against the localnet I think we have two options: 1) We have a script that will...
> what I would like to do is have the IDs configurable I understand this point and this was already requested by users. In this case though this is not...
This makes sense to me. I don't dispute there there may be no or very little practical value in this, but I would take it into consideration if I was...
I'm also busy with wrapping some other stuff up, but might be able to find some time, perhaps next week, to get the tests to run against localnet. It shouldn't...
@amnn @rvantonder I'm debating whether the `custom_resolve_pkg_name` (and corresponding variables) should be renamed to `custom_resolve_pkg_identifier` because "pkg_name" variables in dependency graph conflating between package name as defined in manifest and...
Well the problem is really with referring to the thing as "package name" since with the resolution hook it's not necessarily a name anymore. E.g. with Sui on-chain resolution hooks...
I think it would just be a renaming in dependency_graph and resolution_graph files. `PM::PackageName` is a type alias to `Symbol` so we can just introduce a new alias like `PackageIdentifier`....
I will change name to `identifier` at the end because otherwise there will be a lot of merge conflicts with commits that are ready from before.
@rvantonder what's the status?
Anchor currently doesn't encode enum discriminants in the IDL so this is not possible.