Kimmo Lehto

Results 287 comments of Kimmo Lehto

That's strange. It looks like the command `install -m 0644 /dev/null /etc/k0s/certs.d/gpu-workstation:30101/hosts.toml` fails which creates an empty file with `0644` permissions. It looks like it didn't use `sudo` but I...

Requires some changes, but it's doable.

I think we're manually caching just the docker-builder deps like: ```yaml - name: Cache GOMODCACHE uses: actions/cache@v3 with: key: unittests-k0s-linux-amd64-gomodcache-${{ hashFiles('go.sum') }} restore-keys: | build-k0s-linux-amd64-gomodcache-${{ hashFiles('go.sum') }} path: | build/cache/go/mod...

`sync.OnceValue` was introduced in go1.21, so there has to be two files with buildtags as validator supports older go versions.

> coverage: 74.285% (-0.006%) from 74.291% The coverage check does not seem to calculate correctly when files with build tags are involved.

> Just a quick reminder, wouldn't be `k0s install --force` a viable alternative to this? Yes but less conventional.

I don't know. It's perhaps a bit more conventional but also it's one more place to fiddle with configuration.

The release pipeline is already quite simple. I would see goreleaser as only adding complexity by introducing yet another configuration file + syntax and any trimming of the Makefile then...

This may be more relevant again due to some new use cases

Hmm, I suppose the `static` needs to be regenerated somehow