Kimmo Lehto

Results 287 comments of Kimmo Lehto

Go doc comments [should](https://tip.golang.org/doc/comment) be complete sentences too. You could still edit the remaining problems manually after this has performed the first round of adding missing dots.

> Upon reviewing your Kubernetes CustomResourceDefinition (CRD) YAML for clusterconfigs.k0s.k0sproject.io, there were no obvious typos or missing punctuation. - *ChatGPT*

K0sctl writing two separate extra args is definitely a bug if that happens.

* [ ] https://github.com/k0sproject/k0s/blob/main/inttest/common/footloosesuite.go#L113 * [ ] https://github.com/k0sproject/k0s/blob/main/pkg/component/controller/kine.go#L50 * [ ] https://github.com/k0sproject/k0s/blob/main/pkg/component/controller/etcd.go#L58 * [ ] https://github.com/k0sproject/k0s/blob/main/pkg/component/worker/certificate_manager.go#L38 * [ ] https://github.com/k0sproject/k0s/blob/main/pkg/leaderelection/lease_pool.go#L53 * [ ] https://github.com/k0sproject/k0s/blob/main/pkg/autopilot/controller/updates/updater.go#L39

This is because you have given k0sbinarypath. K0sctl does not know what version that binary is. There is supposed to be a check to see if the file has changed:...

It's possible the sudo output parsing / formatting has some bug in it or it fails to consider timezones. Stat is run with these params (depending on if `--format` is...

Or maybe the `touch` failed that should set the modtime after upload 🤔

All SANs manipulation was removed from k0sctl as k0s does it on its own. Looks like some of them were not redundant.

It was made in https://github.com/k0sproject/k0sctl/pull/772/commits/fd0ba50f48005339846446ffc2452db015e90272 `spec.api.externalAddress`, the private address and `127.0.0.1` used to be added to sans.