Phil Pluckthun

The implementation in this branch passes tests but uses `UNSET`. However, there's an alternative here: https://github.com/JoviDeCroock/graphql-js/commit/1ee3f42d6101e9755a7103bca3316006ba6ec901, which has some updated tests. Basically, the spec proposal uses `CoerceArgumentValues` (which itself is...

@acao: Cheers! I forgot to add some more cases for the original failing matches ✌️ Those should be added in: https://github.com/graphql/graphiql/pull/3518/commits/057f22e378bd74d13928917b1541c81704aa94e7 Regarding the readme, I did test the extension manually...

@acao Merged that back 👍 I'm not too concerned either. No idea what the syntax currently says for single line `graphql(" \"\"\"comment\"\"\" query { id }")` cases, but the original...

Just came back from some holidays, so coming back to this, let me know if there's anything else we want to do here, or if we're good to go ✌️❤️

@acao: re. not matching past multiple lines, I found a more detailed discussion [here](https://github.com/microsoft/vscode-textmate/issues/41), which is where I initially ended up for this PR. Basically, what I meant was that...

It has already been released: https://marketplace.visualstudio.com/items?itemName=GraphQL.vscode-graphql-syntax

I'll take a look! I've tested this before in VSCode, but I'm guessing there's either a case that isn't covered or I made a mistake while resolving conflicts 🤔

Not your job and not your job solely if you do consider it your job ❤️ I did confirm and double-check this, but it was a subtle mistake where the...

Fix is in a new PR here ❤️ https://github.com/graphql/graphiql/pull/3545 Sorry for messing this up!

Personally, I'm a little torn on this. Of course, turning a `Source` into an `OperationResultSource` is “trivial” and `withPromise` could be exported, there's something to be said about: - this...