Phil Pluckthun

Results 299 comments of Phil Pluckthun

@probablyup: Do we still want to fix this. I'm going through old issues and this one seems to be related to duplicate instances still and: - https://github.com/styled-components/styled-components/blob/d96101a102b59a8f9ac4b6f278594674897282bb/packages/styled-components/src/models/GlobalStyle.ts#L18 - https://github.com/styled-components/styled-components/blob/d96101a102b59a8f9ac4b6f278594674897282bb/packages/styled-components/src/models/GlobalStyle.ts#L29 Which,...

I'm not really caught up on this, and I don't really understand what is found to be so attractive for some in duplicating loads of dependencies, instead of having a...

@wdfinch Correct me if I'm wrong, but the `namespace` option should hopefully then resolve this limitation, right?

@wdfinch Yep, that's still intended. However, this is a hash based on component IDs and the contents of the CSS string, so collisions will be extremely unlikely given the namespace...

Just a note on the above, this case isn't limited to peer dependencies. Yarn often actually resolves dependencies on the same package to different versions in workspaces unfortunately 😓 This...

@Noitidart We’re already utilising it and are not planning to give it up 👍 It doesn’t actually provide a huge perf boost as per my research (yet) but it’s definitely...

Hm, I'm going to be extremely honest here — I haven't thought about the grouping and ordering in the internal sheet code in months, so my thoughts on this may...

Well, it depends on whether any rehydration happens on the client-side because currently we basically use server-ordering to initialize client-ordering. Admittedly, we can maybe reduce that somehow, but the problem...

So, to just write this down, I think what I was thinking about last, in terms of what could work was to change the sheet logic to this: 1. server-side:...

I found additional problems with this approach; The first problem is I'd love to avoid work by not having to run "rehydration" of all styled-components' related styles beforehand. This obviously...