Phil Pluckthun comments

Results 299 comments of


                                            Phil Pluckthun

Operations get duplicated

Closing due to inactivity with the explanation above

QueryArgs `variables` type seems to be broken with TypedDocumentNode

Hiya, sorry to drop the ball here for a bit! :wave: It took me a little to realise and identify when this would occur and which cases we forgot. @jaschaephraim:...

Make useQuery work with with getDataFromTree (server side rendering)

I've recently worked on a more elegant solution for this that's temporary until actual suspense lands in React. It still applies the two pass approach, but it should be more...

Make useQuery work with with getDataFromTree (server side rendering)

@trojanowski It supports the current spec/API for suspense, so you can throw a promise any time and as `react-ssr-prepass` is walking the tree it'll queue them up and suspend on...

allocated value is incorrectly aligned

I'm not sure if this is related or whether it’s a coincidence — but with Rust 1.70.0 targeting the `wasm32-wasi` target I’m currently seeing a misalignment that leads to a...

Feature Request: Support for class props other than className

Just leaving a note here; I think the original issue suggests a solution, and personally, I don't really see a problem with it. I believe `stylis` does support `:global` and...

Breaks toHaveStyle assertions in v5.2.0

Sorry, I'll have to close this for now due to inactivity. I'm pretty sure this related to https://github.com/styled-components/jest-styled-components, right? In general, this is also an issue that's unrelated to the...

Transient props (with a $) are not available to a styled component when used in "as"

Why would we expect this? Transient props are there so that they're never passed and only available to styling rules 🤔 In case of props being actually passed you want...

Transient props (with a $) are not available to a styled component when used in "as"

@probablyup I think it is but that being said, maybe usually it does work because of folding? I think we may have not payed enough attention to `as={C}` behaving identically...

Transient props (with a $) are not available to a styled component when used in "as"

@probablyup This could be changed in v6, but we did also get some issues re. folding, since that's potentially a little confusing and only works because of it. So, given...