Albert Meltzer

Results 144 comments of Albert Meltzer

@WojciechMazur @LeeTibbert sorry for multiple attempts to run checks, couldn't figure out how to test locally. helps improve #2324.

> I'm 6+ hours into looking at the Issue and this PR and have run out of time for today. Let me report what I have found so far in...

I have another commit I prepared as an option, I like it a little better but didn't test it as much: https://github.com/scala-native/scala-native/commit/adb9a81a6ecb7503c91c21e2ce95926cb5275eb7

> kitbellew > > > helps improve #2324. > Are you working on scalafmt? Is that where this particular regex popped up? > scalafmt was wicked fast when I had...

> It takes time but I'd like to see (and capture) both the current SN failure and understand both RE2 and javalib `Matcher.scala` possible, feasible, & infeasible issues. Regarding the...

> I took a quick look at the scalameta url you provided. I'll certainly take two minutes wall-clock time off a CI run. For this case, native is slower overall...

Forgot about this, my apologies, @LeeTibbert . > kitbellew @WojciechMazur > > I'm 4+ days into studying this PR, an alternate commit in this PR, the existing SN javalib and...

@LeeTibbert here's a solution which doesn't touch RE2 code at all.

> @kitbellew Does scalafmt use Java region or did you develop workarounds when SN did not support it? workaround indeed.

@TonioGela please take a look at #883 and see if there's anything else left here.