Albert Meltzer

replace binaryCompatVar with a field annotation and full unapply

3

Fixes #2881, by making private vars into "official" fields akin to other ones, and by introducing a full unapply (with all fields) and changing `Liftables` to use that instead.

Step 1 for #2869.

Also suggested by @olafurpg in [#405](https://github.com/scalameta/scalameta/issues/405#issuecomment-222133672) and is a prerequisite for #2820.

scala3: incomplete support for `_` in types

14

https://dotty.epfl.ch/docs/reference/changed-features/wildcards.html describes this: - scala 2: - type wildcard is `_` - type placeholder is unsupported - scala 3.0: - type wildcard is `?` and `_` - type placeholder is...

Also, set a higher rank (policy applied later). Fixes #3520.

Just like we did earlier with minus for computing negative values, lets "absorb" any unary op into the numeric or logical constants.

Manifest was changed to AnyRef: a bug? _Originally posted by @kitbellew in https://github.com/scalameta/scalameta/pull/3292#discussion_r1279653282_

It would probably be good to put that into synthetics :thinking: Could you put that into an issue, I can take a look later. Possibly related to #2459 and #1902....

Looks like a bug, we are not interested in the implicit here, but just the type. _Originally posted by @tgodzik in https://github.com/scalameta/scalameta/pull/3292#discussion_r1279581550_

Looks like a bug, but the macro annotations are tricky _Originally posted by @tgodzik in https://github.com/scalameta/scalameta/pull/3292#discussion_r1279580529_