Vasilis Gakias

Results 8 comments of Vasilis Gakias

May I pick this issue ? Since it is my first actual contribution to OSS it may take some time

Cool! I'll check how to create a project in the test org and how to update the mock data.

Hi @gsmet I've run the tests against the https://github.com/hub4j-test-org/github-api twice: - https://github.com/hub4j-test-org/github-api/pull/451 - https://github.com/hub4j-test-org/github-api/pull/452 And I have some questions: 1. In the Contributing guide it is mentioned `Please request access...

Hi @gsmet, I managed to take a snapshot after modifying the test to add some reactions, fetch again the comment and check the reactions. I've also modified some values that...

HI @bitwiseman I've asked a question [here](https://github.com/github-community/community/discussions/19152). We can wait for an answer and then make our decision for this field. If we need the rest of the changes we...

I've also mentioned this PR in [this apache beam issue](https://github.com/apache/beam/issues/21952) and I am waiting for their feedback on the approach. I'll keep you posted

Changed to draft since jackson was not set properly for parsing every field. This will reduce the performance mentioned in the PR description. I'll check the parsing with all the...

Switched back to gson for the deserialization thread because lots of config is required for jackson to work as expected for all the fields, nevertheless the performance improvement from the...