github-api icon indicating copy to clipboard operation
github-api copied to clipboard

No start_line/line in GHPullRequestReviewComment

Open turbanoff opened this issue 2 years ago • 2 comments

Describe the bug https://docs.github.com/en/rest/pulls/comments#get-a-review-comment-for-a-pull-request Github states that review comment has following fields:

 "start_line": {
        "type": [
          "integer",
          "null"
        ],
        "description": "The first line of the range for a multi-line comment.",
        "examples": [
          2
        ]
      },
      "original_start_line": {
        "type": [
          "integer",
          "null"
        ],
        "description": "The first line of the range for a multi-line comment.",
        "examples": [
          2
        ]
      },
      "start_side": {
        "type": [
          "string",
          "null"
        ],
        "description": "The side of the first line of the range for a multi-line comment.",
        "enum": [
          "LEFT",
          "RIGHT",
          null
        ],
        "default": "RIGHT"
      },
      "line": {
        "description": "The line of the blob to which the comment applies. The last line of the range for a multi-line comment",
        "type": "integer",
        "examples": [
          2
        ]
      },
      "original_line": {
        "description": "The line of the blob to which the comment applies. The last line of the range for a multi-line comment",
        "type": "integer",
        "examples": [
          2
        ]
      },

But there are no such fields in current API (class GHPullRequestReviewComment)

Expected behavior GHPullRequestReviewComment contains all fields which are provided by GitHub

Additional context Thank you for wonderful library! ❤️

turbanoff avatar May 30 '22 20:05 turbanoff

May I pick this issue ? Since it is my first actual contribution to OSS it may take some time

kisaga avatar Jun 01 '22 16:06 kisaga

Go for it.

bitwiseman avatar Jun 02 '22 04:06 bitwiseman