Kirk Baird
Kirk Baird
Hey, you're right seems this repo hasn't had PRs merged for a while. I'm not sure who was previously in charge of this repo. I haven't worked on this repo...
I made this PR cause it is a security vulnerability that currently exists but it is included as part or the BLS stand. Do you this it should be it's...
I've added this in #79
Force pushed to add Sign-off
So https://github.com/miracl/amcl/version3/rust simply copied the code from https://github.com/apache/incubator-milagro-crypto-rust. I was going to reach out to miracl shortly as I have started pushing some changes to the development branch of https://github.com/apache/incubator-milagro-crypto-rust,...
Yep that the plan, or maybe to see if `miracl` would also like to push their changes upstream too so we have one consistent repo.
I think that it is acceptable to have a secret key of zero as all functions will handle it adequately. - Pairings `e(inf, x) = e(x, inf)` - Multiplications: `[0]G...
> > If you are confident that Eth2 will never ever ever attempt to use the VRF-ish properties of BLS signatures, then maybe sk = 0 really isn't a problem...
> > The issue is the the signatures of `sk = 0` are not unique. > > How is that an issue for RANDAO in Eth2 phase 0 @kirk-baird? As...
> What happens with 0 point on aggregation? This is a good point, if `sk = 0` is invalid then we should really reject it in aggregate signature verification (and...