signature-schemes icon indicating copy to clipboard operation
signature-schemes copied to clipboard

Published 20 hours ago • verified publisher icon lovesh

Update Readme link

Open kirk-baird opened this issue 5 years ago • 5 comments

Minor change to the README.md to reflect AMCL have change where the repo sits.

kirk-baird avatar Aug 08 '19 00:08 kirk-baird

Force pushed to add Sign-off

kirk-baird avatar Aug 08 '19 00:08 kirk-baird

The link in Readme is wrong anyway but AMCL used underneath is https://github.com/miracl/amcl and not https://github.com/apache/incubator-milagro-crypto-rust. I see that miracl/amcl is more frequently updated and maintained by M.Scott. Whats the deal with incubator-milagro-crypto-rust?

lovesh avatar Aug 23 '19 05:08 lovesh

So https://github.com/miracl/amcl/version3/rust simply copied the code from https://github.com/apache/incubator-milagro-crypto-rust. I was going to reach out to miracl shortly as I have started pushing some changes to the development branch of https://github.com/apache/incubator-milagro-crypto-rust, and I think it would be much more productive if we were all putting out changes together.

Let me know if you think it's a good idea to combined all the work in one place

kirk-baird avatar Aug 23 '19 22:08 kirk-baird

@kirk-baird I find the code at https://github.com/miracl/amcl/tree/master/version3/rust more recent than at apache/incubator-milagro-crypto-rust. Do you plan to keep reconciling the changes?

lovesh avatar Aug 28 '19 15:08 lovesh

Yep that the plan, or maybe to see if miracl would also like to push their changes upstream too so we have one consistent repo.

kirk-baird avatar Aug 30 '19 00:08 kirk-baird