Kinto

Results 16 comments of Kinto

Hey @baslat, sounds good to me! And no stress @MattCowgill :) ## On URLs You're right, the functions I've written don't accept a full query URL. They only accept the...

Thanks so much @baslat! I like all of those suggestions. I think giving the option to run chunk queries is a great idea. On first glance, I think it should...

Stellar! Totally agree regarding names. I like both of your options. The one thing that would be nice is to pick a naming scheme which allows all three api functions...

Thanks very much for your review @HughParsonage ! I've just addressed your comments and added patch I mentioned which allows the datakey to be passed through as a named list....

Hey all, I just had a look at that example. Strangely, it appears that there actually isn't data for 2012-2014 in that table: ![image](https://user-images.githubusercontent.com/61998181/175882145-fd6d8433-8515-4ee7-bbac-eaf67d9e7f51.png) [ Link here](https://explore.data.abs.gov.au/vis?tm=ABS_REGIONAL_ASGS2016&pg=0&hc[dataflowId]=ABS_REGIONAL_ASGS2016&df[ds]=DATA_BY_REGION_TOPICS&df[id]=ABS_REGIONAL_ASGS2016&df[ag]=ABS&df[vs]=1.2.0&pd=%2C&dq=..0.A&ly[cl]=TIME_PERIOD&ly[rw]=MEASURE) The 500/504 errors...

Hey both, if you're happy to merge without 'chunking' implemented, then I'm happy to put the finishing touches on and write up some unit tests. I'll have a fair bit...

Hi again, I had another look and it's actually more polished than I remember so there weren't really too many finishing touches to add. I just wrote up tests covering...

Hey Matt, I just wanted to follow up on this to see where you got to with it? I think I'm about to enter a fairly busy period, so may...

@MattCowgill Stellar! Thanks :) If we want to keep `labelled` in `Suggests`, which I think is reasonable, then I reckon we should add a `label=TRUE` default arg to these functions...

Woohoo! 🎉 Thanks @baslat and @MattCowgill for your help! and thanks @HughParsonage for your review!