Martin Kinkelin

Results 756 comments of Martin Kinkelin

A few failures, looking like exception backtraces are incomplete with optimized code (although the frame pointers are kept).

> I am not sure this related, maybe try with `apk add libunwind-dev` Thx, but that gives: ``` $ apk add libunwind-dev ERROR: unable to select packages: libunwind-dev-1.8.1-r0: breaks: llvm-libunwind-19.1.4-r1[!libunwind-dev]...

The current CI errors suggest an incomplete config for the *built* (non-installed) compiler. Let me know if you need help.

> Are those cmake quotes interfering with my command's quotes or is there some other reason it's failing? Not sure, I'd need to check locally. In general, using the `sh`...

> 1. Add back the help text in the config files as now they're just settings Ah yeah that'd be good. > I think I change the post build commands...

Yeah I didn't mean to encourage anything like that, just saying that some guys might already use such stuff, regardless of whether by accident or knowing what they are doing....

Note that I'd be okay with generating the ldc2.conf *directory* exclusively now via CMake, so no more support for the single file (as part of the CMake build - but...

> As in remove the CONF_PREFER_DIR=OFF code? Exactly. Again, not sure how much that would simplify the code; you already found a way for the portable concat of all files...

> I can take care of the CI packages, would want to e.g. redo the macOS package configs anyway, now somewhat easier by adding separate files instead of appending multiple...

Okay, this was my final review pass now, just a few nits remaining. I wanna follow-up on https://github.com/ldc-developers/ldc/pull/4954#discussion_r2160065476 after this, shuffling around the order and filenames a bit.