Martin Kinkelin

Results 756 comments of Martin Kinkelin

Support building phobos against a system copy of zlib

> > FWIW, I didn't think anyone would really use the `etc.c.zlib` C bindings directly > > std.zlib is not good for streaming. > > e.g. in iopipe, I have...

Wish: accept *.obj on par with *.o for non-Windows targets

For linking? I assume you can just pass the object files as linker flags then - `-LmyWeirdObject.obj`.

Add "Posix" global version conditional for Emscripten targets

Superseded by #4750.

cmake: allow building liblphobos with system zlib

Thanks. What's missing is making the compiler link the library, especially/only(?) when linking static Phobos. E.g., by adding it as defaultlib in `ldc2.conf` - something like `-defaultlib=phobos2-ldc,z,druntime-ldc`.

cmake: allow building liblphobos with system zlib

Superseded by #4742.

remove or de-UB --release from the CLI

I'm not convinced - it's the analogon to C's `-DNDEBUG` to disable asserts (incl. bounds checks etc.) by default. Try an LDC build with enabled assertions (incl. LLVM assertions), it's...

remove or de-UB --release from the CLI

Yeah agreed, the name surely isn't ideal. But it's been there for ages, so at least for backwards compatibility, it would need to remain for quite a while anyway. Dub...

remove or de-UB --release from the CLI

I forgot to post that CMake `Release` builds default to `-DNDEBUG`; this might be one reason why I don't have any problem with `-release`.

`core.atomic.atomicStore` and `core.atomic.atomicLoad` calls itself recursively

This isn't a stack overflow. The problem is the alignment - for a 128-bit type, make sure to use `align(16) shared string test = …`.

`core.atomic.atomicStore` and `core.atomic.atomicLoad` calls itself recursively

We can't do a static assert of the type, slices are surely a pretty common type, and never aligned sufficiently. We could add a runtime assertion though, that's done in...