Alexey Kucherenko

Swagger 2.0

1

Hi, What's about plans to support 2.0?

Examples

3

Hi @robtweed, 1. Examples moved to separate repos (easy to run and maintain) 2. `start` event is emitted before checkWorkerPool logic is initiated (to be able to configure checkWorkerPoolDelay) 3....

Hi @robtweed, Please take a look at: https://github.com/sindresorhus/awesome-nodejs#job-queues I think you can add your queue there also. Please check https://github.com/sindresorhus/awesome-nodejs/blob/master/contributing.md

Add CHANGELOG.md

2

Hi @robtweed What do you think about adding CHANGELOG.md file? The goal is to have log any changes in lib and allow to mark breaking changes. Quick example of such...

process.argv[2] !== 'undefined')

5

Hi @robtweed Please take a look: https://github.com/robtweed/ewd-qoper8/blob/master/lib/worker/proto/init.js#L36 I believe that line 36 should be ```js if (process.argv[2] && typeof process.argv[2] !== 'undefined') { ``` However, I think that ```js if...

@robtweed Please take a look at https://github.com/robtweed/ewd-qoper8/blob/master/lib/master/proto/startWorker.js#L127-L130 I think ```js this.worker.list = []; for (var pid in this.worker.process) { this.worker.list.push(parseInt(pid, 10)); } ``` is more correct. Affected methods: `stopWorker`, `startWorker`

introduce overridable

4

Hi @jhnns Based on the discussion here https://github.com/jhnns/rewire/pull/116 instead of using ignore, introduced `options.overridable`

Hi @robtweed Just a note for you. I believe you may know about this problem and know what to do (if it's needed ofc) We just have found a "problem"...