kbcli

kbcli copied to clipboard

Query parameters not respected when processing Location header

1

This happens when creating bulk subscriptions for instance (`?bundlesFilter`).

pierre

Code generated uses flaot64 for price amounts

1

See https://github.com/killbill/kbcli/blob/master/kbmodel/invoice_item.go#L29

sbrossie

Better handling of 404 response codes

2

I had provided a workaround for https://github.com/go-swagger/go-swagger/issues/1929 in https://github.com/killbill/kbcli/pull/26 and had confirmed it works for 400 and 401 errors. We just had a report that it might not be enough...

pierre

ProcessLocationHeader parameters not always respected

1

For APIs returning both 201 and 204 (e.g. `createInstantPayment`), `isCreateRequest` is `false` [here](https://github.com/killbill/go-swagger/blob/dbac45d36c93ef8b59e37b80fbf580cc7b8146d3/generator/templates/client/client.gotmpl#L82) and the code to respect the `ProcessLocationHeader` parameter isn't generated. Compare [CreateTaxItems](https://github.com/killbill/kbcli/blob/1de73876f846b10d6b9402cd280df946ea59dff3/kbclient/invoice/invoice_client.go#L746) with [CreateInstantPayment](https://github.com/killbill/kbcli/blob/1de73876f846b10d6b9402cd280df946ea59dff3/kbclient/invoice/invoice_client.go#L483).

pierre

sbrossie

Add CI job to regenerate the client

1

Following the steps [here](https://github.com/killbill/kbcli/blob/master/README.md#client-code-generation), create a Ci job to automatically regenerate the code

sbrossie