kbcli icon indicating copy to clipboard operation
kbcli copied to clipboard

Better handling of 404 response codes

Open pierre opened this issue 3 years ago • 2 comments

I had provided a workaround for https://github.com/go-swagger/go-swagger/issues/1929 in https://github.com/killbill/kbcli/pull/26 and had confirmed it works for 400 and 401 errors.

We just had a report that it might not be enough for some 404 responses (see discussion).

pierre avatar Apr 06 '22 09:04 pierre

/cc @sbrossie / @andrenpaes / @vlademetal in case you've encountered the issue too?

pierre avatar Apr 06 '22 09:04 pierre

I've been trying to reproduce this for a couple of hours and the only way I was able to remotely trigger anything is if the mime type isn't returned (though that isn't a case that should be handled beyond the existing error). In all cases, including 404, where the mime type was text/html, your fix worked correctly

hibrid avatar Sep 05 '23 09:09 hibrid