Kieran Martin

lint package and add asserthat

4

resolves #92 and #95

lintrs on test files

2

Test files fail lintr currently, but not being picked up by cicd. Should be fixed in seperate PR

branch naming convention

1

Now we are moving to a feature branch workflow, can we be consistent about branch naming? I suggest \_\

custom expectation for testthat

3

A nice integration might be to have something like expect_equal_df for testthat. This could generate nice error messages for the testing reportt

controlling what is checked

3

i'm noticing that we are getting to the point of having a huge number of options to turn off warnings for particular things. I'm thinking that it would actually be...

Should diffdf care about data frame class

2

Right now diffdf doesn't care if one object it compares is a tibble and one is a data.table, as they are both data.frames. I'm thinking it probably should? At least...

One piece of feedback was that it would be useful to have an output in markdown format so it can easily be copied to a larger report.

enhance the file output

3

I was thinking that if you are outputting a file it's probably because you want an audit trail. Currently all they get is "no issues found!". Ideally I'd want something...

It might be nice to do a lintr pass to tidy up the code a bit

Hex sticker

1

I feel like we should probably make a diffdf hex sticker, everyone seems to these days!