Kieran Martin

Hi @benjaminwnelson I think the challenge for this would be that we could calculate this a number of ways. For instance, if column A has a different class in the...

No I just fixed the tests which were noticed by cicd; the remaining tests remain unlinted. I could have fixed it there but thought it was cleaner in a seperate...

@gowerc I would recommend looking at this commit https://github.com/gowerc/diffdf/pull/96/commits/11e47ec387ac47ecd28f99665b5a01d4fadef87a for the assertthat changes in particular. One thing I wasn't sure on is that testthat recommends not depending on the exact...

@gowerc updates made. As a note we currently have identical assertions in the print function and the `get_table` function; I personally think assertions should only be on user facing functions,...

I guess if we just want to do all.equal then this is pretty easy to support. In theory we could support recursion here, but then we'd need to think seriously...

On reflection, this is pretty covered in #26, but I guess is slightly extended.

Couldn't we just wipe it entirely? That is, we run the test, but just don't store the results (at the end we check options for any tests to remove and...

Hmm, that's true, i guess they can just build round it fairly easily, so maybe it's fine.

I thought I'd replied to this, sorry! Yes I agree that this is a bug, as there's still information when we have empty dataframes

Happy to approach it that way, a new issue to discuss how much information to give would be useful. There are certain checks you can do when comparing empty datasets...